ref(pill): Update pill border/bg color #21379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report
|
billyvg
reviewed
Oct 15, 2020
Comment on lines
+145
to
+146
| ${PillValue} { | ||
| ${getPillValueColor}; |
Member
There was a problem hiding this comment.
This is missing a } - but why do we call getPillValueColor here instead of moving into the PillValue styled component?
Member
Author
There was a problem hiding this comment.
oh yeah thanks.. . I am doing like that because I didn't want to pass the prop down 2x
Member
|
Can you please double-check vertical alignment? (eg: acceptance/issue-details-ignored.png) |
priscilawebdev
force-pushed
the
ref/redefine-pill-color
branch
from
c95ff45 to
75edb8b
Compare
priscilawebdev
changed the title
priscilawebdev
force-pushed
the
ref/redefine-pill-color
branch
from
8dc74b1 to
b3d4257
Compare
priscilawebdev
force-pushed
the
ref/redefine-pill-color
branch
from
afc1d1f to
8e2da1a
Compare
priscilawebdev
changed the title
priscilawebdev
added a commit
that referenced
this pull request
Oct 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
We talked offline and the design team approved these changes 😉