Skip to content

build(eslint): Add simple-import-sort eslint plugin #22104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
billyvg merged 5 commits into from
Nov 20, 2020
Merged

build(eslint): Add simple-import-sort eslint plugin #22104

billyvg merged 5 commits into from
Nov 20, 2020

Conversation

@billyvg
Copy link
Member

@billyvg billyvg commented Nov 17, 2020 •
edited
Loading

This will sort and group our imports by the filename (the part after from).

@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2020 •
edited
Loading

size-limit report

Path Size
public/app.js 276.35 KB (+0.15% 🔺)
public/vendor.js 594.5 KB (-0.03% 🔽)
public/sentry.css 34.3 KB (0%)

@billyvg billyvg force-pushed the build/eslint/testing-eslint-plugin-simple-import-sort branch from e7849a7 to 9d4f163 Compare November 20, 2020 02:20
@billyvg
Copy link
Member Author

billyvg commented Nov 20, 2020

I will follow-up and move this to our eslint config, as well as applying to getsentry.

@billyvg billyvg requested a review from a team November 20, 2020 02:26
@billyvg
Copy link
Member Author

billyvg commented Nov 20, 2020

There's a circular import issue with incidentRules/presets

@billyvg billyvg mentioned this pull request Nov 20, 2020
Merged
@billyvg billyvg force-pushed the build/eslint/testing-eslint-plugin-simple-import-sort branch from 9d4f163 to e7f2157 Compare November 20, 2020 22:14
@billyvg billyvg marked this pull request as ready for review November 20, 2020 23:13
@billyvg billyvg requested a review from a team November 20, 2020 23:13
@billyvg billyvg requested review from a team as code owners November 20, 2020 23:13
@billyvg billyvg requested review from a team and removed request for a team November 20, 2020 23:13
@billyvg billyvg force-pushed the build/eslint/testing-eslint-plugin-simple-import-sort branch from e7f2157 to b10956f Compare November 20, 2020 23:24
evanpurkhiser
evanpurkhiser approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@evanpurkhiser evanpurkhiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it

@billyvg billyvg merged commit b8bf859 into master Nov 20, 2020
@billyvg billyvg deleted the build/eslint/testing-eslint-plugin-simple-import-sort branch November 20, 2020 23:55
matejminar pushed a commit that referenced this pull request Nov 23, 2020
@billyvg @matejminar
build(eslint): Add simple-import-sort eslint plugin (#22104)
4bf52a3 
This will sort and group our imports by the filename (the part after from). Also note, this is auto-fixable.
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@evanpurkhiser evanpurkhiser evanpurkhiser approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@billyvg @evanpurkhiser