ci(release): Move to getsentry/publish for releases #22657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/workflows/release.yml
Outdated
| action: prepare | ||
| version: ${{ env.RELEASE_VERSION }} | ||
| env: | ||
| ZEUS_API_TOKEN: ${{ secrets.ZEUS_API_TOKEN }} |
Member
There was a problem hiding this comment.
Why do we still need the Zeus token here? Isn't Zeus used for publishing, and we're no longer publishing from here?
Member
Author
There was a problem hiding this comment.
Zeus is also to upload artifacts but let me check.
Seems like you are right, I'll axe it too.
chadwhitacre
approved these changes
Dec 14, 2020
Member
chadwhitacre
left a comment
chadwhitacre
left a comment
There was a problem hiding this comment.
Some q's, no blockers.
Did not test.
BYK
added a commit
to getsentry/snuba
that referenced
this pull request
Dec 15, 2020
A copy of getsentry/sentry#22657 with fixes included
BYK
added a commit
to getsentry/relay
that referenced
this pull request
Dec 15, 2020
A copy of getsentry/sentry#22657 with fixes included
This was referenced Dec 15, 2020
BYK
added a commit
to getsentry/self-hosted
that referenced
this pull request
Dec 15, 2020
A copy of getsentry/sentry#22657 with fixes included
BYK
added a commit
to getsentry/snuba
that referenced
this pull request
Dec 15, 2020
A copy of getsentry/sentry#22657 with fixes included
BYK
added a commit
to getsentry/self-hosted
that referenced
this pull request
Dec 15, 2020
A copy of getsentry/sentry#22657 with fixes included. That said this one is a bit different. We used to use the extra option `no-merge` when publishing to keep the release branches and also keep master on nightly versions. If we want to keep this, we need to add per-project overrides to getsentry/publish which would increase complexity at this early stage for this fringe case. Instead, I opted to follow what getsentry/sentry does: merge but then immediately after that update the version.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.