ref(dynamic-sampling): Apply minor adjusts#23686
Merged
Merged
Conversation
Contributor
size-limit report
|
priscilawebdev
force-pushed
the
ref/dynamic-sampling-apply-few-feedback
branch
from
e5ffd0d to
aca5e38
Compare
priscilawebdev
force-pushed
the
ref/dynamic-sampling-apply-few-feedback
branch
from
aca5e38 to
cfbf873
Compare
priscilawebdev
changed the title
priscilawebdev
force-pushed
the
ref/dynamic-sampling-apply-few-feedback
branch
from
cfbf873 to
e7e37af
Compare
priscilawebdev
commented
Feb 8, 2021
Member
Author
There was a problem hiding this comment.
this was necessary for the field to be 40px; height
priscilawebdev
force-pushed
the
ref/dynamic-sampling-apply-few-feedback
branch
from
574eab5 to
df34b75
Compare
markstory
reviewed
Feb 8, 2021
| <Fields> | ||
| <SelectField | ||
| label={t('Category')} | ||
| help={t('This is a description')} |
Member
Author
There was a problem hiding this comment.
yes..it's temporary 😉
| /> | ||
| <StyledField | ||
| label={t('Match Conditions')} | ||
| help={t('This is a description')} |
Member
There was a problem hiding this comment.
I would omit this so it doesn't get left behind by accident.
Member
Author
There was a problem hiding this comment.
@jan-auer please do you already have a description for these fields?
…Sampling/modals/conditionFields.tsx Co-authored-by: Mark Story <mark@sentry.io>
priscilawebdev
force-pushed
the
ref/dynamic-sampling-apply-few-feedback
branch
from
ee1c7e6 to
e4b7ce9
Compare
markstory
approved these changes
Feb 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
. Add tooltip with description on Add/Drag button when disabled
. Increase Modal size
. Replaced Match TextField with a TextArea component:
Before:
smaller device:
After:
smaller device: