feat(ui): Hide unnecessary suggested assignees#23817
Merged
Merged
Conversation
Contributor
size-limit report
|
scttcper
reviewed
Feb 12, 2021
| return ( | ||
| this.getSuggestedAssignees() | ||
| // filter out suggested assignees if one is already selected | ||
| ?.filter( |
Contributor
Author
There was a problem hiding this comment.
haha i can edit it if you want
i also realize it looks kinda weird with the comment just placed in between :248/:250
scttcper
approved these changes
Feb 12, 2021
|
Deployment failed with the following error: |
bruno-garcia
pushed a commit
that referenced
this pull request
Feb 12, 2021
If a suggested assignee is already selected it doesn't need to be shown in the suggested list for the assignee selector. This PR filters the list of suggested assignees to not include a suggestion if it is currently used as the assignee.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a suggested assignee is already selected it doesn't need to be shown in the suggested list for the assignee selector. This PR filters the list of suggested assignees to not include a suggestion if it is currently used as the assignee.
Example where the suggestion is hidden after being used:
Fixes: WOR-526