feat(demo): adds middleware to log user in automatically #24317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markstory
reviewed
Mar 9, 2021
Member
markstory
left a comment
markstory
left a comment
There was a problem hiding this comment.
Would be good to have some tests around member selection and fail safes.
src/sentry/demo/middleware.py
Outdated
| # on organization pages | ||
| def process_view(self, request, view_func, view_args, view_kwargs): | ||
| if not settings.DEMO_MODE: | ||
| return |
Member
There was a problem hiding this comment.
I would raise an exception here so that the application fails to start as an additional precaution.
| return | ||
|
|
||
| # if authed, no action required | ||
| if request.user.is_authenticated() and request.user.is_active: |
Member
There was a problem hiding this comment.
If the user is logged in but not part of the demo org would they hit errors viewing the demo org data? You might want to coerce their session into the demo org they are looking at.
Contributor
Author
There was a problem hiding this comment.
@markstory good point. It's sort of an edge case but it's possible someone could be logged in for on demo but receive a link for another org's demo. In that case, we should switch the user.
markstory
approved these changes
Mar 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to log a user into the demo automatically if they land on an organization page in the demo. The purpose of this is to allow users to share links with other people when trying out the demo. While this would be a security vulnerability in SaaS, this should be totally fine in the demo instance for a few reasons. First, one would have to guess an org slug to get access which wouldn't be easy because we auto-generate them using
petname. Secondly, we only givememberaccess meaning that a user who guesses a slug would have limited abilities to take destructive action on someone else's demo.