Skip to content

Conversation

@scefali
Copy link
Contributor

@scefali scefali commented Mar 15, 2021

Looks like another PR (#24396) that was merged broke the code added in another PR (#24317) since I didn't rebase after merging the first one.

@scefali scefali changed the title fix tests fix(demo): fixes tests Mar 15, 2021
@scefali scefali marked this pull request as ready for review March 15, 2021 16:34
@scefali scefali enabled auto-merge (squash) March 15, 2021 16:35
@armenzg armenzg self-requested a review March 15, 2021 16:42
Copy link
Member

@armenzg armenzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just approving to get the tests fixed on master.
If you need tech review feel free to find a more appropriate reviewer.

@scefali
Copy link
Contributor Author

scefali commented Mar 15, 2021

I'm just approving to get the tests fixed on master.
If you need tech review feel free to find a more appropriate reviewer.

@armenzg nah, just need a rubber stamp 👍

@scefali scefali merged commit b94ed3b into master Mar 15, 2021
@scefali scefali deleted the scefali/fix-master-3-15 branch March 15, 2021 16:56
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants