fix(ui): Add a no padding empty state message for panels#24433
Merged
taylangocmen merged 2 commits intorr/alert-detailsfrom Mar 15, 2021
Merged
Conversation
taylangocmen
requested review from
a team and
robinrendle
and removed request for
a team
Contributor
size-limit report
|
taylangocmen
deleted the
taylangocmen/alert-details-nopadding-empty-message
branch
taylangocmen
added a commit
that referenced
this pull request
Mar 16, 2021
* fix(ui): alert details * made alert rule header consistent with other pages * fixed alert details edit button text * fix(ui): Add a no padding empty state message for panels (#24433) * fix(ui): Add a no padding empty state message for panels * style(lint): Auto commit lint changes Co-authored-by: sentry-internal-tools[bot] <66042841+sentry-internal-tools[bot]@users.noreply.github.com> * Update src/sentry/static/sentry/app/views/alerts/rules/details/timeline.tsx * Update src/sentry/static/sentry/app/views/alerts/rules/details/timeline.tsx * rename element * remove nopadding Co-authored-by: Taylan Gocmen <taylangocmen@users.noreply.github.com> Co-authored-by: sentry-internal-tools[bot] <66042841+sentry-internal-tools[bot]@users.noreply.github.com> Co-authored-by: Taylan Gocmen <ta.gocmen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty alert message looks like this:
It should look like this to be consistent with panel styles, but we don't want the extra padding since this is a sidebar element