feat(demo): adds more guides for demo mode#24718
Merged
Merged
Conversation
Contributor
size-limit report
|
scefali
commented
Mar 25, 2021
| let labelString = label; | ||
| if (React.isValidElement(label)) { | ||
| label = label?.props?.children ?? label; | ||
| labelString = label?.props?.children ?? label; |
Contributor
Author
There was a problem hiding this comment.
I introduced a bug here that only impacted demo mode (the guides on the sidebar didn't actually mount because we only rendered the child).
scefali
commented
Mar 25, 2021
| type={type} | ||
| title={ | ||
| <GuideAnchor target="breadcrumbs" position="bottom"> | ||
| <GuideAnchor target="breadcrumbs" position="right"> |
Contributor
Author
There was a problem hiding this comment.
this change makes the guide look a bit better
scttcper
approved these changes
Mar 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds more guides to demo mode and fixes a bug with guides that were added earlier (#24649). The following guides have been added: