Skip to content

feat(alert): Custom metric for alert wizard#25005

Merged
davidenwang merged 4 commits into
masterfrom
davidenwang/wizard-custom-metric
Apr 7, 2021
Merged

feat(alert): Custom metric for alert wizard#25005
davidenwang merged 4 commits into
masterfrom
davidenwang/wizard-custom-metric

Conversation

@davidenwang

Copy link
Copy Markdown
Contributor

Adds a new option for a custom metric in the alert wizard (this will enable fp, ttfb which were removed in this dependent PR #24974).

image

@davidenwang davidenwang requested a review from a team April 6, 2021 19:21
@davidenwang davidenwang changed the base branch from master to davidenwang/delete-fp-ttfb April 6, 2021 19:21
@github-actions

github-actions Bot commented Apr 6, 2021

Copy link
Copy Markdown
Contributor

size-limit report

Path Base Size (d521dbf) Current Size Change
public/app.js 319.89 KB 321.67 KB +0.56% 🔺
public/vendor.js 596.24 KB 596.26 KB +0.01% 🔺
public/sentry.css 23.9 KB 24.48 KB +2.45% 🔺

@scttcper

scttcper commented Apr 6, 2021

Copy link
Copy Markdown
Member

more options good

@davidenwang davidenwang force-pushed the davidenwang/delete-fp-ttfb branch from f6c19f7 to c53b20c Compare April 7, 2021 18:35
Base automatically changed from davidenwang/delete-fp-ttfb to master April 7, 2021 19:03
@davidenwang davidenwang force-pushed the davidenwang/wizard-custom-metric branch from 6f400c9 to 4dbec00 Compare April 7, 2021 19:05
@davidenwang davidenwang enabled auto-merge (squash) April 7, 2021 19:05
@davidenwang davidenwang merged commit 1f76221 into master Apr 7, 2021
@davidenwang davidenwang deleted the davidenwang/wizard-custom-metric branch April 7, 2021 19:28
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants