Skip to content

fix(performance): Use a single event view as source for "Open in Discover" button #25051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dashed merged 1 commit into from
Apr 7, 2021
Merged

fix(performance): Use a single event view as source for "Open in Discover" button #25051

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 19 additions & 15 deletions src/sentry/static/sentry/app/components/discover/transactionsList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,9 +142,21 @@ class TransactionsList extends React.Component<Props> {
});
};

getEventView() {
const {eventView, selected} = this.props;

const sortedEventView = eventView.withSorts([selected.sort]);
if (selected.query) {
const query = tokenizeSearch(sortedEventView.query);
selected.query.forEach(item => query.setTagValues(item[0], [item[1]]));
sortedEventView.query = stringifyQueryObject(query);
}

return sortedEventView;
}

renderHeader(): React.ReactNode {
const {
eventView,
organization,
selected,
options,
Expand Down Expand Up @@ -184,9 +196,7 @@ class TransactionsList extends React.Component<Props> {
<GuideAnchor target="release_transactions_open_in_discover">
<DiscoverButton
onClick={handleOpenInDiscoverClick}
to={eventView
.withSorts([selected.sort])
.getResultsViewUrlTarget(organization.slug)}
to={this.getEventView().getResultsViewUrlTarget(organization.slug)}
size="small"
data-test-id="discover-open"
>
Expand All @@ -201,10 +211,8 @@ class TransactionsList extends React.Component<Props> {

renderTransactionTable(): React.ReactNode {
const {
eventView,
location,
organization,
selected,
handleCellAction,
cursorName,
limit,
Expand All @@ -213,14 +221,10 @@ class TransactionsList extends React.Component<Props> {
baseline,
forceLoading,
} = this.props;
const sortedEventView = eventView.withSorts([selected.sort]);
const columnOrder = sortedEventView.getColumns();

const eventView = this.getEventView();
const columnOrder = eventView.getColumns();
const cursor = decodeScalar(location.query?.[cursorName]);
if (selected.query) {
const query = tokenizeSearch(sortedEventView.query);
selected.query.forEach(item => query.setTagValues(item[0], [item[1]]));
sortedEventView.query = stringifyQueryObject(query);
}

const baselineTransactionName = organization.features.includes(
'transaction-comparison'
Expand All @@ -231,7 +235,7 @@ class TransactionsList extends React.Component<Props> {
let tableRenderer = ({isLoading, pageLinks, tableData, baselineData}) => (
<React.Fragment>
<TransactionsTable
eventView={sortedEventView}
eventView={eventView}
organization={organization}
location={location}
isLoading={isLoading}
Expand Down Expand Up @@ -279,7 +283,7 @@ class TransactionsList extends React.Component<Props> {
return (
<DiscoverQuery
location={location}
eventView={sortedEventView}
eventView={eventView}
orgSlug={organization.slug}
limit={limit}
cursor={cursor}
Expand Down