ref(integration-platform): limit app management to managers/owners#25458
Merged
MeredithAnya merged 3 commits intoApr 21, 2021
Conversation
scefali
reviewed
Apr 20, 2021
scefali
left a comment
scefali
left a comment
Contributor
There was a problem hiding this comment.
Hmmm what about admins? And why are we making this change?
scefali
reviewed
Apr 20, 2021
scefali
reviewed
Apr 20, 2021
| > | ||
| {t('New Internal Integration')} | ||
| </Button> | ||
| <Access organization={organization} access={['org:integrations']}> |
Contributor
There was a problem hiding this comment.
@MeredithAnya If we are excluding admins, I don't think this will work since admins have the org:integrations scope.
Member
Author
There was a problem hiding this comment.
oh yeah this needs to be org:write
Member
Author
@scefali updated the PR description with more context |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces scopes for creating and updating sentry apps (either public or internal) to
ManagersorOwners. Because sentry apps either have access to all projects or none,MembersandAdminscan create integrations that haveproject:readorevent:readscopes and can access issue data that belongs to projects they are not apart of. This is fine for organizations with open membership (as any member can choose to join any team and therefore get access), however this is a security concern for closed membership organizations.UI Tooltips:
Same tooltip for both the Public and Internal integration buttons, just with slightly different text: