feat(native): Support uploading BCSymbolMap DIFs#25712
Merged
Merged
Conversation
Adds support for uploading BCSymbolMap and their associated PLists which map their DebugIDs. This allows sentry-cli to upload these files and allows symbolicator to fetch them.
This was referenced Apr 28, 2021
Swatinem
reviewed
Apr 29, 2021
Swatinem
left a comment
Swatinem
left a comment
Contributor
There was a problem hiding this comment.
lgtm. Proguard looks special in that case since the debug_id is extracted from the filename, although it might be appealing to unify this somehow, I wouldn’t worry about that.
Otherwise we get the filename of the tempfile which is pretty not nice.
flub
commented
May 5, 2021
The proguard files should not be included here, but everything else should be. So extend the query to cover all known and new types.
untitaker
approved these changes
May 6, 2021
untitaker
left a comment
untitaker
left a comment
Member
There was a problem hiding this comment.
i've been roped in because of dep upgrade but the rest looks fine too (ignoring that I don't know the context)
Swatinem
approved these changes
May 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for uploading BCSymbolMap and their associated PLists
which map their DebugIDs. This allows sentry-cli to upload these
files and allows symbolicator to fetch them.
Related PRs:
getsentry/sentry-cli#952
getsentry/symbolic#373
getsentry/symbolicator#414