Skip to content

fix(dashboards): Pass environment for table widgets#25726

Merged
dashed merged 6 commits into
masterfrom
fix-dashboard-pass-global-selection
Apr 28, 2021
Merged

fix(dashboards): Pass environment for table widgets#25726
dashed merged 6 commits into
masterfrom
fix-dashboard-pass-global-selection

Conversation

@dashed

@dashed dashed commented Apr 28, 2021

Copy link
Copy Markdown
Member

I've added tests to ensure the global selection header are appropriately passed for the API endpoints for the timeseries, table, world map, and big number widgets.

@wmak wmak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 minor comment, but LGTM

Comment thread tests/js/spec/views/dashboardsV2/widgetQueries.spec.jsx Outdated
Comment thread static/app/views/dashboardsV2/utils.tsx Outdated
Comment thread tests/js/spec/views/dashboardsV2/widgetQueries.spec.jsx Outdated
Comment thread tests/js/spec/views/dashboardsV2/widgetQueries.spec.jsx Outdated
Comment thread tests/js/spec/views/dashboardsV2/widgetQueries.spec.jsx Outdated
@dashed dashed requested a review from Zylphrex April 28, 2021 19:20
@dashed dashed merged commit 139dcd7 into master Apr 28, 2021
@dashed dashed deleted the fix-dashboard-pass-global-selection branch April 28, 2021 19:46
@github-actions github-actions Bot locked and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants