feat(symbolicator): Option comparing stackwalkers (flagr)#25812
Merged
Conversation
flub
changed the title
Symbolicator has a new per-request option to test a new stackwalker, this sentry option allows us to turn this on for a small ratio of the requests so we can assess the performance and quality impacts without impacting normal production. This version relies on Flagr only enabling this for a percentage of the requests, see the flag on flagr: https://flagr.getsentry.net/#/flags/67
loewenheim
force-pushed
the
feat/symbolicator-compare-stackwalking-flagr
branch
from
2a6805c to
7baf5dd
Compare
Swatinem
approved these changes
May 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symbolicator has a new per-request option to test a new stackwalker,
this sentry option allows us to turn this on for a small ratio of
the requests so we can assess the performance and quality impacts
without impacting normal production.
This version relies on Flagr only enabling this for a percentage
of the requests, see the flag on flagr:
https://flagr.getsentry.net/#/flags/67
See also the alternative without flagr: #25807
This also needs a PR in getsentry and needs the feature to land in symbolicator (PRs to be linked here when they exist)