ref: Refactor transaction post processing#25826
Merged
Conversation
This is the first step towards removing transactions from post processing entirely. It simply groups the post processing transaction code so it can be more easily refactored later. The only functional change included here is that the metric `events.processed` is no longer inclusive of transactions.
wedamija
approved these changes
May 3, 2021
src/sentry/tasks/post_process.py
Outdated
Comment on lines
+215
to
+224
| # Re-bind node data to avoid renormalization. We only want to | ||
| # renormalize when loading old data from the database. | ||
| event.data = EventDict(event.data, skip_renormalization=True) | ||
|
|
||
| # Re-bind Project and Org since we're reading the Event object | ||
| # from cache which may contain stale parent models. | ||
| event.project = Project.objects.get_from_cache(id=event.project_id) | ||
| event.project._organization_cache = Organization.objects.get_from_cache( | ||
| id=event.project.organization_id | ||
| ) |
Member
There was a problem hiding this comment.
We could probably move this before the if is_transaction_event statement and just share it for events and transactions
wedamija
approved these changes
May 3, 2021
JoshFerge
pushed a commit
that referenced
this pull request
May 4, 2021
This is the first step towards removing transactions from post processing entirely. It simply groups the post processing transaction code so it can be more easily refactored later. The only functional change included here is that the metric events.processed is no longer inclusive of transactions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first step towards removing transactions from
post processing entirely. It simply groups the post
processing transaction code so it can be more easily refactored
later.
The only functional change included here is that the metric
events.processedis no longer inclusive of transactions.