feat(trace-view): Add an event when trace has >1 project#25839
Merged
Conversation
- Also add tags for projects in the trace grouped, this is cause the existing num_projects tag is the number of projects in the query
Zylphrex
approved these changes
May 4, 2021
Member
Zylphrex
left a comment
Zylphrex
left a comment
There was a problem hiding this comment.
Would be nice to be more explicit where we see this analytic that this is the number of traces viewed with more than 1 project rather than the total number of traces.
Member
Author
|
@Zylphrex good idea, added trace_id so we can count_unique on it |
k-fish
approved these changes
May 4, 2021
|
|
||
| sentry_sdk.set_tag("trace_view.trace", trace_id) | ||
| sentry_sdk.set_tag("trace_view.transactions", len_transactions) | ||
| sentry_sdk.set_tag("trace_view.transactions.grouped", group_length(len_transactions)) |
JoshFerge
pushed a commit
that referenced
this pull request
May 4, 2021
* feat(trace-view): Add an event when trace has >1 project - Also add tags for projects in the trace grouped, this is cause the existing num_projects tag is the number of projects in the query
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
existing num_projects tag is the number of projects in the query