fix(quick-trace): Loading state between light and full results#25850
Merged
fix(quick-trace): Loading state between light and full results#25850
Conversation
When the light results error, this should not be emitted. Instead, it should remain in a loading state and wait for the full results to load.
wmak
approved these changes
May 4, 2021
k-fish
approved these changes
May 4, 2021
JoshFerge
pushed a commit
that referenced
this pull request
May 4, 2021
When the light results error, this should not be emitted. Instead, it should remain in a loading state and wait for the full results to load.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the light results error, this should not be emitted. Instead, it should
remain in a loading state and wait for the full results to load.