fix(perf): Return standardized tag keys and tag values#25862
Merged
Conversation
Previously we were returning values directly from snuba (eg. sentry:release instead of just release), which isn't helpful since we usually want to put a tag key and value right back into a query. This re-uses the same functions that event-facets uses to standardize the tag data.
Zylphrex
approved these changes
May 4, 2021
wmak
reviewed
May 4, 2021
src/sentry/api/endpoints/organization_events_facets_performance.py
Outdated
Show resolved
Hide resolved
…e.py Co-authored-by: William Mak <william@wmak.io>
wmak
approved these changes
May 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously we were returning values directly from snuba (eg.
sentry:release:ab31b23...instead of justrelease:ab31b23...), which isn't helpful since we usually want to put a tag key and value right back into a query. This re-uses the same functions that event-facets uses to standardize the tag data.