Conversation
Passing key_transactions to the issues endpoint doesn't work and currently causes an error, so this PR will hide the issues components when that tag is present as a workaround. Refs VIS-716
dashed
reviewed
May 4, 2021
| // Filter out key_transaction from being passed to issues as it will cause an error. | ||
| const conditions = tokenizeSearch(queryParams.query); | ||
| conditions.removeTag('key_transaction'); | ||
| queryParams.query = stringifyQueryObject(conditions); |
Member
There was a problem hiding this comment.
@k-fish this should be performed in the getIssuesEndpoint() method of this component.
k-fish
deleted the
fix/perf-transaction-summary-block-key-transaction-related-issues
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Passing key_transactions to the issues endpoint doesn't work and currently causes an error, so this PR will hide the issues components when that tag is present as a workaround.
Refs VIS-716