feat(dashboards): Added Breadcrumbs to the Dashboard Details page#25943
Merged
Conversation
Dashboard details page is now a sub page for business plan and has breadcrumbs. The manage page will be the main container for business plan. for Team plans however, the default dashboard is still the main page. User now also may not delete the last dashboard.
dashed
reviewed
May 7, 2021
| priority="danger" | ||
| message={t('Are you sure you want to delete this dashboard?')} | ||
| onConfirm={onDelete} | ||
| disabled={!(dashboards.length > 1)} |
Member
There was a problem hiding this comment.
@shruthilayaj We also may need to prevent deleting the last dashboard for the API endpoint.
Member
There was a problem hiding this comment.
Nit: Can we simplify the negation here and just do dashboards.length <= 1?
…, rename dashboard to default dashboard if dashboard manager is enabled
doralchan
approved these changes
May 8, 2021
doralchan
left a comment
doralchan
left a comment
Contributor
There was a problem hiding this comment.
Looks good from the design end
dashed
approved these changes
May 10, 2021
priscilawebdev
pushed a commit
that referenced
this pull request
May 11, 2021
…5943) Dashboard details page is now a sub page for business plan and has breadcrumbs. The manage page will be the main container for business plan. for Team plans however, the default dashboard is still the main page. User now also may not delete the last dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dashboard details page is now a sub page for business plan
and has breadcrumbs. The manage page will be the main container
for business plan. for Team plans however, the default dashboard
is still the main page. User now also won't be able to delete the last
dashboard.