feat(perf): Add span ops to trends#25945
Merged
Merged
Conversation
This will let us find trends in ops breakdowns, if the user is part of the ops breakdown EA.
dashed
approved these changes
May 7, 2021
Zylphrex
approved these changes
May 10, 2021
Zylphrex
left a comment
Zylphrex
left a comment
Member
There was a problem hiding this comment.
Something like http spans, db spans etc reads nicer here imo. But we already use spans.http, spans.db, etc in discover.
priscilawebdev
pushed a commit
that referenced
this pull request
May 11, 2021
* feat(perf): Add span ops to trends This will let us find trends in ops breakdowns, if the user is part of the ops breakdown EA.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This will let us find trends in ops breakdowns, if the user is part of
the ops breakdown EA.
Would like some feedback on the name in the column (eg.
Spans (db)vs.DB Spansor something else)Screenshot