feat(demo): adds input to skip email and allows camel case post body#25967
Merged
Conversation
markstory
approved these changes
May 10, 2021
markstory
left a comment
markstory
left a comment
Member
There was a problem hiding this comment.
Looks like cookies being set 🍪
priscilawebdev
pushed a commit
that referenced
this pull request
May 11, 2021
This PR makes two changes with the demo start view: Add a skipEmail input which will set the skip_email cookie on the response. When the browser detects the skip_email cookie, we will not show the modal which asks for the user's email. We will use this when deep linking from within Sentry for users that already have accounts. Allow camel case inputs for the existing skipBuffer and acceptedTracking inputs. Snake case is still allowed for now. Once I have updated the client to send only camel case, I will remove the snake case options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes two changes with the demo start view:
skipEmailinput which will set theskip_emailcookie on the response. When the browser detects theskip_emailcookie, we will not show the modal which asks for the user's email. We will use this when deep linking from within Sentry for users that already have accounts.skipBufferandacceptedTrackinginputs. Snake case is still allowed for now. Once I have updated the client to send only camel case, I will remove the snake case options.What the modal looks like:
