fix(GithubEnterpriseIntegration): Adding Authorization-header for installations-request

[itssimple]

GitHub Enterprise has deprecated using access_token only in querystring.

Response from newer versions:

{
    "message": "Must specify access token via Authorization header",
    "documentation_url": "https://docs.github.com/enterprise/3.0/v3/#oauth2-token-sent-in-a-header"
}

[BYK]

/gcbrun

[BYK]

Thanks a lot @itssimple! I think this was overlooked when fixing the main GitHub auth a while ago.

Pinging the @getsentry/ecosystem team for a review and merge.

[MeredithAnya]

@itssimple Thank you putting up this PR !

Just a couple of things:

I would recommend adding match_querystring=True to the responses made to the /user endpoints in the GHE tests to just verify that we are making requests without the access token in the query param. (even though we are mocking out the response)

Here is one of the requests, the other is some lines above:

sentry/tests/sentry/integrations/github_enterprise/test_integration.py

Lines 97 to 101 in 1bd0ad9

	responses.add(
	responses.GET,
	self.base_url + "/user/installations",
	json={"installations": [{"id": installation_id}]},
	)

Additionally, can you tell me which version of GHE you tested this out on?

[MeredithAnya]

Let's remove the params here since you are adding the access_token to the headers now

[itssimple]

@MeredithAnya Thanks for checking the PR!

I have committed the changes requested by adding the match_querystring=True to the test, and removing the params from the actual request.

I'm testing this against a 3.0.7 version of GHE.

[BYK]

/gcbrun

[MeredithAnya]

@MeredithAnya Thanks for checking the PR!

I have committed the changes requested by adding the match_querystring=True to the test, and removing the params from the actual request.

I'm testing this against a 3.0.7 version of GHE.

Thanks for removing the params ! The match_querystring=True is a new arg, not part of the json so i think needs to be like the following

responses.add(
    responses.GET,
    self.base_url + "/user/installations",
    json={"installations": [{"id": installation_id}]},
    match_querystring=True,
) 

after that I think things should be good

[itssimple]

Ah, sorry. It's my first time modifying Python. :)

[BYK]

/gcbrun

[BYK]

/gcbrun

[BYK]

/gcbrun

[BYK]

/gcbrun

[MeredithAnya]

we got this team !

fix lint once and for all