Skip to content

fix(GithubEnterpriseIntegration): Adding Authorization-header for installations-request #26281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 1, 2021
Merged

fix(GithubEnterpriseIntegration): Adding Authorization-header for installations-request #26281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
be39528
fix(GithubEnterpriseIntegration): Adding Authorization-header for ins…
itssimple May 28, 2021
c51dbf5
fix(GitHub Enterprise): Removed query param from request
itssimple Jun 1, 2021
ada872f
test(GitHub Enterprise): Added `match_querystring` to installations r…
itssimple Jun 1, 2021
3d33da1
test(GitHub Enterprise): Added the match_querystring at the wrong level.
itssimple Jun 1, 2021
e292f15
Fix lint
BYK Jun 1, 2021
eedd455
f-strings ftw
BYK Jun 1, 2021
c014b2f
fix lint once and for all
BYK Jun 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/sentry/integrations/github_enterprise/integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,8 +311,10 @@ def get_installation_info(self, installation_data, access_token, installation_id

resp = session.get(
"https://{}/api/v3/user/installations".format(installation_data["url"]),
params={"access_token": access_token},
headers={"Accept": "application/vnd.github.machine-man-preview+json"},
headers={
"Accept": "application/vnd.github.machine-man-preview+json",
"Authorization": f"token {access_token}",
},
verify=installation_data["verify_ssl"],
)
resp.raise_for_status()
Expand Down
1 change: 1 addition & 0 deletions tests/sentry/integrations/github_enterprise/test_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ def assert_setup_flow(
responses.GET,
self.base_url + "/user/installations",
json={"installations": [{"id": installation_id}]},
match_querystring=True,
)

resp = self.client.get(
Expand Down