feat(notifications platform): More robust message tab reply #26581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceorourke
force-pushed
the
ceorourke/API-1814
branch
from
d8e66d2 to
2666382
Compare
mgaeta
reviewed
Jun 14, 2021
|
|
||
| class SlackEventMessageBuilder(BlockSlackMessageBuilder): | ||
| def build(self) -> SlackBody: | ||
| def build(self, **kwargs: Any) -> SlackBody: |
Contributor
There was a problem hiding this comment.
Move the integration parameter from the build method to the constructor:
def __init__(self, integration: Integration) -> None:
super().__init__()
self.integration = integration
mgaeta
reviewed
Jun 14, 2021
|
|
||
| HEADER_MESSAGE = "Here are the commands you can use. Commands not working? Re-install the app!" | ||
| DM_COMMAND_HEADER = "*Direct Message Commands:*" | ||
| DM_COMMANDS_MESSAGE = "• `/sentry link`: Link your Slack account to Sentry \n • `/sentry unlink`: Unlink your Slack account from Sentry\n • `/sentry help`, `help`: View this list of commands" |
Contributor
There was a problem hiding this comment.
You should make a mapping of commands to descriptions that we can reuse and then do something like:
DM_COMMANDS_MESSAGE = "\n".join((
f"• `/sentry {command}`: {description}"
for command, description in sorted(tuple(AVAILABLE_COMMANDS.items()))
))
mgaeta
suggested changes
Jun 14, 2021
Contributor
mgaeta
left a comment
mgaeta
left a comment
There was a problem hiding this comment.
I left comments about 2 changes.
mgaeta
approved these changes
Jun 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a lot more information to the Sentry Slack app message tab reply (this replies to anything typed in the message tab) to let users know about the new functionality. This is feature flagged so users without the feature still see this:
But those with the feature see all this:
