fix: Create a new File when rewriting artifact index#26655
Merged
Conversation
jjbayer
commented
Jun 16, 2021
| if create: | ||
| self._ensure_releasefile() | ||
|
|
||
| # No race condition here, because artifact index is never deleted |
Member
Author
There was a problem hiding this comment.
Unless user deletes all release artifacts via sourcemaps endpoint.
untitaker
approved these changes
Jun 16, 2021
jan-auer
approved these changes
Jun 16, 2021
| releasefile = None | ||
|
|
||
| if releasefile is None: | ||
| index_data = None |
Member
There was a problem hiding this comment.
This is the only branch where index_data can be None, and then the only remaining thing this function does is yield None. Can we bail out here instead?
Member
Author
There was a problem hiding this comment.
You could probably do something like
yield None
return
but I'm not sure if that would improve readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider
Fileimmutable, so create a new one any time the artifact index is updated.