fix(releases): Change release adoption tooltip date to interval#26792
Merged
taylangocmen merged 3 commits intoJun 22, 2021
Conversation
scttcper
approved these changes
Jun 22, 2021
matejminar
reviewed
Jun 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the exact interval each point in the release adoption chart represents to the tooltip. The 1d period for the chart (when 14d is selected) is different from the 1d period for the Active Users. The last point in the chart is different than the list. The shifted intervals in #26777 isn't going to work, so updated the tooltip to clear the confusion as much as I can.
Also limited the chart to mobile and desktop projects for now.
BEFORE:
AFTER:
