ref(notification settings): Read team settings#26876
Merged
Merged
Conversation
ceorourke
changed the title
ceorourke
force-pushed
the
ceorourke/API-1952
branch
from
001c6f8 to
70f6d62
Compare
mgaeta
reviewed
Jun 28, 2021
mgaeta
reviewed
Jun 28, 2021
mgaeta
reviewed
Jun 29, 2021
mgaeta
suggested changes
Jun 29, 2021
mgaeta
left a comment
mgaeta
left a comment
Contributor
There was a problem hiding this comment.
I left a code block in a comment that you can use to remove the hack.
mgaeta
approved these changes
Jun 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a team has notification settings for their projects enabled for Slack, read those settings and notify them when a new issue comes in for one of the team's projects that has an issue alert enabled.
Also add tests to ensure we don't send notifications for projects no longer in the team, and that we do send notifications for new projects added to the team.
This is what a
NotificationSettingrow looks like for a team Slack notification:scope_typescope_identifierprovidertypevaluetarget_idteam_idteam.actor_id