feat(spans): Embed span trees of transactions that are direct children#26903
Conversation
Zylphrex
left a comment
Zylphrex
left a comment
There was a problem hiding this comment.
This is great! so much easier to follow than it used to be.
| return null; | ||
| } | ||
|
|
||
| if (transactions && transactions.length === 1) { |
There was a problem hiding this comment.
This will only support spans with 1 child transaction at the moment right?
There was a problem hiding this comment.
That's right. I aim to support the case of 2 or more children in a follow up pull request once this prototype validates well.
| <DividerContainer> | ||
| {this.renderDivider(dividerHandlerChildrenProps)} | ||
| {this.renderErrorBadge(errors)} | ||
| {this.renderEmbeddedTransactionsBadge(transactions)} |
There was a problem hiding this comment.
I assume the case where there's is both an error and a child transaction will be left as a TODO item?
There was a problem hiding this comment.
Yep. I'm going to follow up in another pull request that will include some hover state effects to be able to support this.
|
|
||
| this.embeddedChildren = [parsedRootSpan]; | ||
| }) | ||
| ) |
There was a problem hiding this comment.
This can be a followup but should this handle the .catch case and display an error or something?
There was a problem hiding this comment.
There definitely should be a .catch() here. I refactored to roll up the loading and error states into this.fetchEmbeddedChildrenState.
dashed
force-pushed
the
embedded-transaction
branch
from
9d03fa7 to
59a16c8
Compare
2 participants
Using the information provided by the trace navigation feature, we can identify transactions that are direct children to the current transaction, and embed their span trees into the current span view.
For example, this enables customers to be able to see backend transactions inline with the frontend spans.
This product feature will be gated behind the
organizations:unified-span-viewfeature flag.Functionality that appears to be missing will be added in follow-up pull-requests.
Kapture.2021-06-25.at.17.27.33.mp4