fix(ui): Remove Skip Onboarding #27457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the option to skip onboarding because a user would still need to set up a project as a first step anyway.
scefali
reviewed
Jul 14, 2021
Contributor
scefali
left a comment
scefali
left a comment
There was a problem hiding this comment.
@Neo-Zhixing can you take a screenshot of the easter egg before and after your change?
scefali
approved these changes
Jul 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the option to skip onboarding because a user would still need to set up a project as a first step anyway.
Note that the FallingError easter egg is still there. When
fallCountis 0, nothing will be displayed, and I return<br />to maintain the appropriate spacing.Before:
After:
