feat(codeowners): ProjectOwnership validation blocks codeowner paths#27643
Merged
AniketDas-Tekky merged 2 commits intomasterfrom Jul 21, 2021
Merged
feat(codeowners): ProjectOwnership validation blocks codeowner paths#27643AniketDas-Tekky merged 2 commits intomasterfrom
AniketDas-Tekky merged 2 commits intomasterfrom
Conversation
Codeowners should only be able to be added through importing a codeowners file. In order to prevent a user from modifying their issue owners to add a codeowners path, ProjectOwnershipSerializer now validates that there are no "codeowners" matcher types in the raw lines. Bonus: made matcher types constants in grammar.py Fixes API-1968
Member
MeredithAnya
left a comment
MeredithAnya
left a comment
There was a problem hiding this comment.
Might be nice to update the Matcher docstring to mention codeowners and module matcher types, in addition to a note about the codeowners matcher being invalid for issue owner syntax
|
|
||
| @staticmethod | ||
| def _validate_no_codeowners(rules: List[Rule]): | ||
| """codeowner matcher types cannot be added via ProjectOwnership, only via github""" |
Member
There was a problem hiding this comment.
might just be me catching up here, but you can still add a codeowner file via the API directly right? which would just be using the ProjectCodeOwners table instead.
only via github is a little confusing to me because we have gitlab too (supposedly) and i thought manually as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codeowners should only be able to be added through importing a codeowners file. In order to prevent a user from modifying their issue owners to add a codeowners path, ProjectOwnershipSerializer now validates that there are no "codeowners" matcher types in the raw lines.
Bonus: made matcher types constants in grammar.py
Fixes API-1968