Conversation
Stall percentage is always visible in the mobile landing table but only shows as needed in the vital cards. This change makes it consistent to ensure that it only shows when react-native projects are selected.
k-fish
approved these changes
Jul 21, 2021
| // At this point, all projects are mobile projects. | ||
| // If in addition to that, all projects are react-native projects, | ||
| // then show the stall percentage as well. | ||
| const projectIds = genericEventView.project; |
Member
There was a problem hiding this comment.
Yeah this is fine for now, I think we can pull this out later when we do auto-display for mobile.
dashed
approved these changes
Jul 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stall percentage is always visible in the mobile landing table but only shows as
needed in the vital cards. This change makes it consistent to ensure that it
only shows when react-native projects are selected.