fix(gitlab): Handle JSONDecodeError#27682
Merged
Merged
Conversation
Contributor
|
I think we should only use "error_status": e.code if hasattr(e, "code") else req.status_code,or "error_status": getattr(e, "code", req.status_code),or except JSONDecodeError as e:
code = req.status_code
self.logger(...)
except Exception as e:
code = e.code
self.logger(...) |
mgaeta
approved these changes
Jul 22, 2021
mgaeta
left a comment
Contributor
There was a problem hiding this comment.
Looks good but you should leave a comment explaining why e.code might not exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are getting a
JSONDecodeErrorwhen gitlab responds back with a301on refreshing identities because we attempt to get the status code from the decoded json when there isn't any. Let's just use the response code from thereqso that we actually can log the refresh failures (currently we aren't logging it at all)FIXES SENTRY-RKE