Skip to content

fix(django 2.2): rename view method to avoid clashing #28312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshuarli merged 1 commit into from
Sep 1, 2021
Merged

fix(django 2.2): rename view method to avoid clashing #28312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/sentry/api/endpoints/organization_events_facets_performance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,10 @@ def has_feature(self, organization, request):
def has_tag_page_feature(self, organization, request):
return features.has("organizations:performance-tag-page", organization, actor=request.user)

def setup(self, request, organization):
# NOTE: This used to be called setup, but since Django 2.2 it's a View method.
# We don't fit its semantics, but I couldn't think of a better name, and
# it's only used in child classes.
def _setup(self, request, organization):
if not (
self.has_feature(organization, request)
or self.has_tag_page_feature(organization, request)
Expand All @@ -63,7 +66,7 @@ def setup(self, request, organization):
class OrganizationEventsFacetsPerformanceEndpoint(OrganizationEventsFacetsPerformanceEndpointBase):
def get(self, request, organization):
try:
params, aggregate_column, filter_query = self.setup(request, organization)
params, aggregate_column, filter_query = self._setup(request, organization)
except NoProjects:
return Response([])

Expand Down Expand Up @@ -134,7 +137,7 @@ def has_feature(self, organization, request):

def get(self, request, organization):
try:
params, aggregate_column, filter_query = self.setup(request, organization)
params, aggregate_column, filter_query = self._setup(request, organization)
except NoProjects:
return Response([])

Expand Down