Skip to content

ref(select): Choices -> options issueAlertOptions #28808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidenwang merged 1 commit into from
Oct 28, 2021
Merged

ref(select): Choices -> options issueAlertOptions #28808

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions static/app/views/projectInstall/issueAlertOptions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,12 +115,11 @@ class IssueAlertOptions extends AsyncComponent<Props, State> {
};
}

getAvailableMetricChoices() {
getAvailableMetricOptions() {
return [
[MetricValues.ERRORS, t('occurrences of')],
[MetricValues.USERS, t('users affected by')],
].filter(valueDescriptionPair => {
const [value] = valueDescriptionPair;
{value: MetricValues.ERRORS, label: t('occurrences of')},
{value: MetricValues.USERS, label: t('users affected by')},
].filter(({value}) => {
return this.state.conditions?.some?.(
object => object?.id === METRIC_CONDITION_MAP[value]
);
Expand Down Expand Up @@ -163,14 +162,17 @@ class IssueAlertOptions extends AsyncComponent<Props, State> {
/>
<InlineSelectControl
value={this.state.metric}
choices={this.getAvailableMetricChoices()}
options={this.getAvailableMetricOptions()}
onChange={metric => this.setStateAndUpdateParents({metric: metric.value})}
data-test-id="metric-select-control"
/>
{t('a unique error in')}
<InlineSelectControl
value={this.state.interval}
choices={this.state.intervalChoices}
options={this.state.intervalChoices?.map(([value, label]) => ({
value,
label,
}))}
onChange={interval =>
this.setStateAndUpdateParents({interval: interval.value})
}
Expand Down