Skip to content

Conversation

@scttcper
Copy link
Member

@scttcper scttcper commented Sep 29, 2021

adds the "mixed" aria-checked state when the checkbox is indeterminate
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/checkbox_role

@scttcper scttcper requested a review from a team September 29, 2021 19:56
@scttcper scttcper requested a review from a team as a code owner September 29, 2021 19:56
Copy link
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will be nice to try and replace this with an actual checkbox input and use accent-color to make it sentry purple.

@scttcper scttcper merged commit 99d2059 into master Sep 29, 2021
@scttcper scttcper deleted the scttcper/RTL-checkboxfancy branch September 29, 2021 21:08
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants