perf(js): Avoid rebuilding routes w/ memoization #28975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matejminar
approved these changes
Sep 30, 2021
Member
matejminar
left a comment
matejminar
left a comment
There was a problem hiding this comment.
Good idea, our route tree is fairly large - I wonder if there'll be any measurable difference.
Member
Author
|
Looks like building routes takes ~5ms, so it's not super significant, but I think it's good. |
evanpurkhiser
deleted the
evanpurkhiser/perf-js-avoid-rebuilding-routes-w-memoization
branch
vuluongj20
pushed a commit
that referenced
this pull request
Sep 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.