Skip to content

ref(ui): Remove LightWeightNoProjectMessage #28988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matejminar merged 1 commit into from
Oct 1, 2021
Merged

ref(ui): Remove LightWeightNoProjectMessage #28988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions static/app/components/lightWeightNoProjectMessage.tsx
View file
Open in desktop

This file was deleted.

9 changes: 6 additions & 3 deletions static/app/components/noProjectMessage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,16 @@ import {t} from 'app/locale';
import ConfigStore from 'app/stores/configStore';
import space from 'app/styles/space';
import {Organization, Project} from 'app/types';
import withProjects from 'app/utils/withProjects';

type Props = React.PropsWithChildren<{
organization: Organization;
projects?: Project[];
loadingProjects?: boolean;
projects: Project[];
loadingProjects: boolean;
superuserNeedsToBeProjectMember?: boolean;
}>;

export default function NoProjectMessage({
function NoProjectMessage({
children,
organization,
projects,
Expand Down Expand Up @@ -127,3 +128,5 @@ const Content = styled(Flex)`
const Actions = styled(ButtonBar)`
width: fit-content;
`;

export default withProjects(NoProjectMessage);
10 changes: 5 additions & 5 deletions static/app/views/dashboardsV2/detail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {Client} from 'app/api';
import Breadcrumbs from 'app/components/breadcrumbs';
import HookOrDefault from 'app/components/hookOrDefault';
import * as Layout from 'app/components/layouts/thirds';
import LightWeightNoProjectMessage from 'app/components/lightWeightNoProjectMessage';
import NoProjectMessage from 'app/components/noProjectMessage';
import GlobalSelectionHeader from 'app/components/organizations/globalSelectionHeader';
import {t} from 'app/locale';
import {PageContent} from 'app/styles/organization';
Expand Down Expand Up @@ -403,7 +403,7 @@ class DashboardDetail extends Component<Props, State> {
}}
>
<PageContent>
<LightWeightNoProjectMessage organization={organization}>
<NoProjectMessage organization={organization}>
<StyledPageHeader>
<DashboardTitle
dashboard={modifiedDashboard ?? dashboard}
Expand Down Expand Up @@ -431,7 +431,7 @@ class DashboardDetail extends Component<Props, State> {
router={router}
location={location}
/>
</LightWeightNoProjectMessage>
</NoProjectMessage>
</PageContent>
</GlobalSelectionHeader>
);
Expand All @@ -455,7 +455,7 @@ class DashboardDetail extends Component<Props, State> {
},
}}
>
<LightWeightNoProjectMessage organization={organization}>
<NoProjectMessage organization={organization}>
<Layout.Header>
<Layout.HeaderContent>
<Breadcrumbs
Expand Down Expand Up @@ -510,7 +510,7 @@ class DashboardDetail extends Component<Props, State> {
/>
</Layout.Main>
</Layout.Body>
</LightWeightNoProjectMessage>
</NoProjectMessage>
</GlobalSelectionHeader>
);
}
Expand Down
6 changes: 3 additions & 3 deletions static/app/views/dashboardsV2/manage/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import Feature from 'app/components/acl/feature';
import Alert from 'app/components/alert';
import Button from 'app/components/button';
import DropdownControl, {DropdownItem} from 'app/components/dropdownControl';
import LightWeightNoProjectMessage from 'app/components/lightWeightNoProjectMessage';
import NoProjectMessage from 'app/components/noProjectMessage';
import SearchBar from 'app/components/searchBar';
import SentryDocumentTitle from 'app/components/sentryDocumentTitle';
import {IconAdd} from 'app/icons';
Expand Down Expand Up @@ -191,7 +191,7 @@ class ManageDashboards extends AsyncView<Props, State> {
>
<SentryDocumentTitle title={t('Dashboards')} orgSlug={organization.slug}>
<StyledPageContent>
<LightWeightNoProjectMessage organization={organization}>
<NoProjectMessage organization={organization}>
<PageContent>
<StyledPageHeader>
{t('Dashboards')}
Expand All @@ -210,7 +210,7 @@ class ManageDashboards extends AsyncView<Props, State> {
{this.renderActions()}
{this.renderDashboards()}
</PageContent>
</LightWeightNoProjectMessage>
</NoProjectMessage>
</StyledPageContent>
</SentryDocumentTitle>
</Feature>
Expand Down
6 changes: 3 additions & 3 deletions static/app/views/eventsV2/eventDetails/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import {Component} from 'react';
import {RouteComponentProps} from 'react-router';
import styled from '@emotion/styled';

import LightWeightNoProjectMessage from 'app/components/lightWeightNoProjectMessage';
import NoProjectMessage from 'app/components/noProjectMessage';
import SentryDocumentTitle from 'app/components/sentryDocumentTitle';
import {t} from 'app/locale';
import {PageContent} from 'app/styles/organization';
Expand Down Expand Up @@ -53,7 +53,7 @@ class EventDetails extends Component<Props> {
projectSlug={projectSlug}
>
<StyledPageContent>
<LightWeightNoProjectMessage organization={organization}>
<NoProjectMessage organization={organization}>
<EventDetailsContent
organization={organization}
location={location}
Expand All @@ -63,7 +63,7 @@ class EventDetails extends Component<Props> {
router={router}
route={route}
/>
</LightWeightNoProjectMessage>
</NoProjectMessage>
</StyledPageContent>
</SentryDocumentTitle>
);
Expand Down
6 changes: 3 additions & 3 deletions static/app/views/eventsV2/landing.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import GuideAnchor from 'app/components/assistant/guideAnchor';
import AsyncComponent from 'app/components/asyncComponent';
import Button from 'app/components/button';
import DropdownControl, {DropdownItem} from 'app/components/dropdownControl';
import LightWeightNoProjectMessage from 'app/components/lightWeightNoProjectMessage';
import NoProjectMessage from 'app/components/noProjectMessage';
import SearchBar from 'app/components/searchBar';
import SentryDocumentTitle from 'app/components/sentryDocumentTitle';
import Switch from 'app/components/switchButton';
Expand Down Expand Up @@ -290,7 +290,7 @@ class DiscoverLanding extends AsyncComponent<Props, State> {
>
<SentryDocumentTitle title={t('Discover')} orgSlug={organization.slug}>
<StyledPageContent>
<LightWeightNoProjectMessage organization={organization}>
<NoProjectMessage organization={organization}>
<PageContent>
<StyledPageHeader>
<GuideAnchor target="discover_landing_header">
Expand All @@ -315,7 +315,7 @@ class DiscoverLanding extends AsyncComponent<Props, State> {
{this.renderActions()}
{this.renderComponent()}
</PageContent>
</LightWeightNoProjectMessage>
</NoProjectMessage>
</StyledPageContent>
</SentryDocumentTitle>
</Feature>
Expand Down
6 changes: 3 additions & 3 deletions static/app/views/eventsV2/results.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import Confirm from 'app/components/confirm';
import {CreateAlertFromViewButton} from 'app/components/createAlertButton';
import SearchBar from 'app/components/events/searchBar';
import * as Layout from 'app/components/layouts/thirds';
import LightWeightNoProjectMessage from 'app/components/lightWeightNoProjectMessage';
import NoProjectMessage from 'app/components/noProjectMessage';
import GlobalSelectionHeader from 'app/components/organizations/globalSelectionHeader';
import {getParams} from 'app/components/organizations/globalSelectionHeader/getParams';
import SentryDocumentTitle from 'app/components/sentryDocumentTitle';
Expand Down Expand Up @@ -461,7 +461,7 @@ class Results extends React.Component<Props, State> {
return (
<SentryDocumentTitle title={title} orgSlug={organization.slug}>
<StyledPageContent>
<LightWeightNoProjectMessage organization={organization}>
<NoProjectMessage organization={organization}>
<ResultsHeader
errorCode={errorCode}
organization={organization}
Expand Down Expand Up @@ -533,7 +533,7 @@ class Results extends React.Component<Props, State> {
{this.setOpenFunction}
</Confirm>
</Layout.Body>
</LightWeightNoProjectMessage>
</NoProjectMessage>
</StyledPageContent>
</SentryDocumentTitle>
);
Expand Down
6 changes: 2 additions & 4 deletions static/app/views/issueList/container.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {Component} from 'react';
import DocumentTitle from 'react-document-title';

import LightWeightNoProjectMessage from 'app/components/lightWeightNoProjectMessage';
import NoProjectMessage from 'app/components/noProjectMessage';
import GlobalSelectionHeader from 'app/components/organizations/globalSelectionHeader';
import {Organization} from 'app/types';
import withOrganization from 'app/utils/withOrganization';
Expand All @@ -21,9 +21,7 @@ class IssueListContainer extends Component<Props> {
return (
<DocumentTitle title={this.getTitle()}>
<GlobalSelectionHeader>
<LightWeightNoProjectMessage organization={organization}>
{children}
</LightWeightNoProjectMessage>
<NoProjectMessage organization={organization}>{children}</NoProjectMessage>
</GlobalSelectionHeader>
</DocumentTitle>
);
Expand Down
6 changes: 3 additions & 3 deletions static/app/views/performance/compare/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ import styled from '@emotion/styled';
import * as Sentry from '@sentry/react';

import NotFound from 'app/components/errors/notFound';
import LightWeightNoProjectMessage from 'app/components/lightWeightNoProjectMessage';
import LoadingError from 'app/components/loadingError';
import LoadingIndicator from 'app/components/loadingIndicator';
import NoProjectMessage from 'app/components/noProjectMessage';
import SentryDocumentTitle from 'app/components/sentryDocumentTitle';
import {t} from 'app/locale';
import {PageContent} from 'app/styles/organization';
Expand Down Expand Up @@ -125,9 +125,9 @@ class TransactionComparisonPage extends React.PureComponent<Props> {
>
<React.Fragment>
<StyledPageContent>
<LightWeightNoProjectMessage organization={organization}>
<NoProjectMessage organization={organization}>
{this.renderComparison({baselineEventSlug, regressionEventSlug})}
</LightWeightNoProjectMessage>
</NoProjectMessage>
</StyledPageContent>
</React.Fragment>
</SentryDocumentTitle>
Expand Down
6 changes: 3 additions & 3 deletions static/app/views/performance/content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import Feature from 'app/components/acl/feature';
import Alert from 'app/components/alert';
import Button from 'app/components/button';
import GlobalSdkUpdateAlert from 'app/components/globalSdkUpdateAlert';
import LightWeightNoProjectMessage from 'app/components/lightWeightNoProjectMessage';
import NoProjectMessage from 'app/components/noProjectMessage';
import GlobalSelectionHeader from 'app/components/organizations/globalSelectionHeader';
import PageHeading from 'app/components/pageHeading';
import SentryDocumentTitle from 'app/components/sentryDocumentTitle';
Expand Down Expand Up @@ -211,7 +211,7 @@ class PerformanceContent extends Component<Props, State> {

return (
<PageContent>
<LightWeightNoProjectMessage organization={organization}>
<NoProjectMessage organization={organization}>
<PageHeader>
<PageHeading>{t('Performance')}</PageHeading>
{!showOnboarding && (
Expand Down Expand Up @@ -248,7 +248,7 @@ class PerformanceContent extends Component<Props, State> {
handleSearch={this.handleSearch}
/>
)}
</LightWeightNoProjectMessage>
</NoProjectMessage>
</PageContent>
);
}
Expand Down
6 changes: 3 additions & 3 deletions static/app/views/performance/traceDetails/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import {RouteComponentProps} from 'react-router';
import styled from '@emotion/styled';

import {Client} from 'app/api';
import LightWeightNoProjectMessage from 'app/components/lightWeightNoProjectMessage';
import NoProjectMessage from 'app/components/noProjectMessage';
import {getParams} from 'app/components/organizations/globalSelectionHeader/getParams';
import SentryDocumentTitle from 'app/components/sentryDocumentTitle';
import {ALL_ACCESS_PROJECTS} from 'app/constants/globalSelectionHeader';
Expand Down Expand Up @@ -142,9 +142,9 @@ class TraceSummary extends Component<Props> {
return (
<SentryDocumentTitle title={this.getDocumentTitle()} orgSlug={organization.slug}>
<StyledPageContent>
<LightWeightNoProjectMessage organization={organization}>
<NoProjectMessage organization={organization}>
{this.renderContent()}
</LightWeightNoProjectMessage>
</NoProjectMessage>
</StyledPageContent>
</SentryDocumentTitle>
);
Expand Down
6 changes: 3 additions & 3 deletions static/app/views/performance/transactionDetails/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import {Component} from 'react';
import {RouteComponentProps} from 'react-router';
import styled from '@emotion/styled';

import LightWeightNoProjectMessage from 'app/components/lightWeightNoProjectMessage';
import NoProjectMessage from 'app/components/noProjectMessage';
import SentryDocumentTitle from 'app/components/sentryDocumentTitle';
import {t} from 'app/locale';
import {PageContent} from 'app/styles/organization';
Expand Down Expand Up @@ -36,7 +36,7 @@ class EventDetails extends Component<Props> {
projectSlug={projectSlug}
>
<StyledPageContent>
<LightWeightNoProjectMessage organization={organization}>
<NoProjectMessage organization={organization}>
<Projects orgId={organization.slug} slugs={[projectSlug]}>
{({projects}) => {
if (projects.length === 0) {
Expand All @@ -58,7 +58,7 @@ class EventDetails extends Component<Props> {
router={router}
route={route}
/>
</LightWeightNoProjectMessage>
</NoProjectMessage>
</StyledPageContent>
</SentryDocumentTitle>
);
Expand Down
6 changes: 3 additions & 3 deletions static/app/views/performance/transactionSummary/pageLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import Feature from 'app/components/acl/feature';
import Alert from 'app/components/alert';
import GlobalSdkUpdateAlert from 'app/components/globalSdkUpdateAlert';
import * as Layout from 'app/components/layouts/thirds';
import LightWeightNoProjectMessage from 'app/components/lightWeightNoProjectMessage';
import NoProjectMessage from 'app/components/noProjectMessage';
import GlobalSelectionHeader from 'app/components/organizations/globalSelectionHeader';
import SentryDocumentTitle from 'app/components/sentryDocumentTitle';
import {IconFlag} from 'app/icons';
Expand Down Expand Up @@ -112,7 +112,7 @@ function PageLayout(props: Props) {
showProjectSettingsLink
>
<StyledPageContent>
<LightWeightNoProjectMessage organization={organization}>
<NoProjectMessage organization={organization}>
<TransactionHeader
eventView={eventView}
location={location}
Expand Down Expand Up @@ -149,7 +149,7 @@ function PageLayout(props: Props) {
transactionThresholdMetric={transactionThresholdMetric}
/>
</Layout.Body>
</LightWeightNoProjectMessage>
</NoProjectMessage>
</StyledPageContent>
</GlobalSelectionHeader>
</PerformanceEventViewProvider>
Expand Down
6 changes: 3 additions & 3 deletions static/app/views/performance/trends/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import {RouteComponentProps} from 'react-router';
import styled from '@emotion/styled';

import {Client} from 'app/api';
import LightWeightNoProjectMessage from 'app/components/lightWeightNoProjectMessage';
import NoProjectMessage from 'app/components/noProjectMessage';
import SentryDocumentTitle from 'app/components/sentryDocumentTitle';
import {t} from 'app/locale';
import {PageContent} from 'app/styles/organization';
Expand Down Expand Up @@ -79,9 +79,9 @@ class TrendsSummary extends React.Component<Props, State> {
return (
<SentryDocumentTitle title={this.getDocumentTitle()} orgSlug={organization.slug}>
<StyledPageContent>
<LightWeightNoProjectMessage organization={organization}>
<NoProjectMessage organization={organization}>
{this.renderContent()}
</LightWeightNoProjectMessage>
</NoProjectMessage>
</StyledPageContent>
</SentryDocumentTitle>
);
Expand Down
6 changes: 3 additions & 3 deletions static/app/views/performance/vitalDetail/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import isEqual from 'lodash/isEqual';

import {loadOrganizationTags} from 'app/actionCreators/tags';
import {Client} from 'app/api';
import LightWeightNoProjectMessage from 'app/components/lightWeightNoProjectMessage';
import NoProjectMessage from 'app/components/noProjectMessage';
import GlobalSelectionHeader from 'app/components/organizations/globalSelectionHeader';
import SentryDocumentTitle from 'app/components/sentryDocumentTitle';
import {t} from 'app/locale';
Expand Down Expand Up @@ -109,15 +109,15 @@ class VitalDetail extends Component<Props, State> {
<PerformanceEventViewProvider value={{eventView: this.state.eventView}}>
<GlobalSelectionHeader>
<StyledPageContent>
<LightWeightNoProjectMessage organization={organization}>
<NoProjectMessage organization={organization}>
<VitalDetailContent
location={location}
organization={organization}
eventView={eventView}
router={router}
vitalName={vitalName || WebVital.LCP}
/>
</LightWeightNoProjectMessage>
</NoProjectMessage>
</StyledPageContent>
</GlobalSelectionHeader>
</PerformanceEventViewProvider>
Expand Down
Loading