build(ci): Fix check migration job
#29118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were skipping the job if relevant files were not changed. On GitHub we have to specify the exact job name for the "required" checks. However, when the job has a matrix, it will append the matrix value to the job name. And if you skip a job, the matrix application is skipped, so it will never add the matrix value to the job name. Thus, we could not make this job required as it would never satisfy the checks if the job were skipped. As a hack, we have to skip each individual step in the job.
Member
Author
|
This didn't skip because we modified the workflow. |
evanpurkhiser
approved these changes
Oct 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were skipping the job if relevant files were not changed. On GitHub we have to specify the exact job name for the "required" checks. However, when the job has a matrix, it will append the matrix value to the job name. And if you skip a job, the matrix application is skipped, so it will never add the matrix value to the job name. Thus, we could not make this job required as it would never satisfy the checks if the job were skipped.
As a hack, we have to skip each individual step in the job.