ref(stack-trace-interfaces): Add Native Stack Trace V2 - Part 1 - [INGEST-508] #29434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priscilawebdev
changed the title
priscilawebdev
force-pushed
the
ref/add-threads-interface-new-version
branch
from
57f1a3e to
7b191b7
Compare
priscilawebdev
force-pushed
the
ref/add-threads-interface-new-version
branch
from
7b191b7 to
e8ab71c
Compare
Contributor
size-limit report
|
priscilawebdev
changed the title
priscilawebdev
changed the base branch from
master
to
ref/restructure-crash-content-files
priscilawebdev
changed the title
priscilawebdev
force-pushed
the
ref/add-threads-interface-new-version
branch
from
af84185 to
3db037e
Compare
priscilawebdev
force-pushed
the
ref/add-threads-interface-new-version
branch
from
8e1aefc to
934c85a
Compare
priscilawebdev
force-pushed
the
ref/add-threads-interface-new-version
branch
from
5087bb2 to
5aa142a
Compare
matejminar
reviewed
Oct 25, 2021
Comment on lines
+99
to
+101
| <Button size="small" href={getDownloadHref()}> | ||
| {t('Download')} | ||
| </Button> |
Member
There was a problem hiding this comment.
Does everyone have permission to download this or should it be disabled for some roles?
Member
Author
There was a problem hiding this comment.
According to the old code, everyone have permission to download the file, but good question! I will raise this question internally too
Member
Author
There was a problem hiding this comment.
there is another condition though that I will implement in a follow-up
Member
Author
There was a problem hiding this comment.
matejminar
approved these changes
Oct 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything is feature flagged [
organizations:native-stack-trace-v2]We are currently implementing the new native stack trace design and this PR is only one of many that are to come.
This first implementation brings:
The new component traceEventDataSection, which deals with the
SortBy,OptionsandRawactionsThe traceEventDataSection component folder contains the SortOptions and DisplayOptions component. The Display Option Dropdown is very similar to what we have in the breadcrumbs and images loaded, so we plan to create a reusable core component in the future.
A new Threads interfaced named ThreadsV2 which uses the traceEventDataSection component
ps: Not all checked display options will work now as the stack trace content (frames) needs to be updated. This will be the next PR - #29532
Before:
After