ref(team): Change alert creation/edit views to not rely on withTeams #29585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report
|
davidenwang
force-pushed
the
davidenwang/use-team-util-alert-rules
branch
from
ab9ff28 to
7fb6d06
Compare
evanpurkhiser
approved these changes
Oct 26, 2021
davidenwang
force-pushed
the
davidenwang/use-team-util-alert-rules
branch
from
7fb6d06 to
f1c88a6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the way these views fetch teams to make it more accurate. Currently withTeams will not necessarily supply every team in the organization, which is the assumption the components make when they filter that list down to just member teams.
Replace withTeams -> Teams fetching utility and simplify some
filterlogic since we don't have to explicitly filter fromall teams->member teams