ref(js): Small code cleanup to ProjectsStore

[evanpurkhiser]

No description provided.

[priscilawebdev]

nit: shouldn't we call items projects?

[evanpurkhiser]

Yeah I'll update 👍

[priscilawebdev]

Suggested change

	// Assign stats into projects
	entries.forEach(([projectId, stats]) => {
	this.itemsById[projectId].stats = stats;
	});
	const touchedIds = entries.map(([projectId]) => projectId);
	const touchedIds = entries.map(([projectId, stats]) => {
	// Assign stats into projects
	this.itemsById[projectId].stats = stats;
	return projectId;
	});

[evanpurkhiser]

lol this is what it did before, but I hated that a map had side effects

[priscilawebdev]

I understand, but this way, we don't need to do a 2x loop. Was the side effect negatively affecting anything?

[evanpurkhiser]

The performance difference is completely negligible. (O(2n) is the same as O(n))

The side effect was not affecting anything, but IMO it is harder to read.

From this article: https://glebbahmutov.com/blog/avoid-side-effects-with-immutable-data-structures/

When using immutable data structures instead of JavaScript native objects, our code and data flow becomes easier to understand and reason

[priscilawebdev]

Suggested change

	projects.forEach(project => this.removeTeamFromProject(teamSlug, project));
	const affectedProjectIds = projects.map(project => project.id);
	const affectedProjectIds = projects.map(project => {
	this.removeTeamFromProject(teamSlug, project);
	return project.id;
	});