Skip to content

fix(kafka-headers): Make transaction forwarder header relevant #29618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikhars merged 2 commits into from
Oct 28, 2021
Merged

fix(kafka-headers): Make transaction forwarder header relevant #29618

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b50447a
fix(kafka-headers): Make transaction forwarder header relevant
nikhars Oct 27, 2021
f3e9f7b
Merge branch 'master' into nikhar/transaction-header
nikhars Oct 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/sentry/eventstream/kafka/backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,7 @@ def encode_bool(value: Optional[bool]) -> str:
def strip_none_values(value: Mapping[str, Optional[str]]) -> Mapping[str, str]:
return {key: value for key, value in value.items() if value is not None}

# TODO: Change transaction_forwarder to be intelligent once transaction post process forwarder
# is implemented and caught up with current events post process forwarder.
transaction_forwarder = False
transaction_forwarder = True if event.group_id is None else False

send_new_headers = options.get("eventstream:kafka-headers")

Expand Down