Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion migrations_lockfile.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ To resolve this, rebase against latest master and regenerate your migration. Thi
will then be regenerated, and you should be able to merge without conflicts.

nodestore: 0002_nodestore_no_dictfield
sentry: 0241_grouphistory_null_actor
sentry: 0242_delete_removed_plugin_data
social_auth: 0001_initial
60 changes: 60 additions & 0 deletions src/sentry/migrations/0242_delete_removed_plugin_data.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
# Generated by Django 2.2.24 on 2021-10-28 17:56

from django.db import migrations

from sentry.utils.query import RangeQuerySetWrapperWithProgressBar


def delete_removed_plugin_data(apps, schema_editor):
"""
Delete the rows in the ProjectOption table that relate to plugins we've deleted.
"""
ProjectOption = apps.get_model("sentry", "ProjectOption")
for project_option in RangeQuerySetWrapperWithProgressBar(ProjectOption.objects.all()):
if project_option.key in (
"jira-ac:enabled",
"vsts:default_project",
"vsts:enabled",
"vsts:instance",
"clubhouse:enabled",
"clubhouse:project",
"clubhouse:token",
"teamwork:enabled",
"teamwork:token",
"teamwork:url",
):
project_option.delete()


class Migration(migrations.Migration):
# This flag is used to mark that a migration shouldn't be automatically run in
# production. We set this to True for operations that we think are risky and want
# someone from ops to run manually and monitor.
# General advice is that if in doubt, mark your migration as `is_dangerous`.
# Some things you should always mark as dangerous:
# - Large data migrations. Typically we want these to be run manually by ops so that
# they can be monitored. Since data migrations will now hold a transaction open
# this is even more important.
# - Adding columns to highly active tables, even ones that are NULL.
is_dangerous = True
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went back and forth on whether we needed this to be true or false, the amount of data is fairly small.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably the right choice to make it dangerous, just since the table has 5mm rows and it'll take a while to get through them all


# This flag is used to decide whether to run this migration in a transaction or not.
# By default we prefer to run in a transaction, but for migrations where you want
# to `CREATE INDEX CONCURRENTLY` this needs to be set to False. Typically you'll
# want to create an index concurrently when adding one to an existing table.
# You'll also usually want to set this to `False` if you're writing a data
# migration, since we don't want the entire migration to run in one long-running
# transaction.
atomic = False

dependencies = [
("sentry", "0241_grouphistory_null_actor"),
]

operations = [
migrations.RunPython(
delete_removed_plugin_data,
migrations.RunPython.noop,
hints={"tables": ["sentry_projectoptions"]},
)
]