-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
ref(plugins): Remove deleted plugins project options #29645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| # Generated by Django 2.2.24 on 2021-10-28 17:56 | ||
|
|
||
| from django.db import migrations | ||
|
|
||
| from sentry.utils.query import RangeQuerySetWrapperWithProgressBar | ||
|
|
||
|
|
||
| def delete_removed_plugin_data(apps, schema_editor): | ||
| """ | ||
| Delete the rows in the ProjectOption table that relate to plugins we've deleted. | ||
| """ | ||
| ProjectOption = apps.get_model("sentry", "ProjectOption") | ||
| for project_option in RangeQuerySetWrapperWithProgressBar(ProjectOption.objects.all()): | ||
| if project_option.key in ( | ||
| "jira-ac:enabled", | ||
| "vsts:default_project", | ||
| "vsts:enabled", | ||
| "vsts:instance", | ||
| "clubhouse:enabled", | ||
| "clubhouse:project", | ||
| "clubhouse:token", | ||
| "teamwork:enabled", | ||
| "teamwork:token", | ||
| "teamwork:url", | ||
| ): | ||
| project_option.delete() | ||
|
|
||
|
|
||
| class Migration(migrations.Migration): | ||
| # This flag is used to mark that a migration shouldn't be automatically run in | ||
| # production. We set this to True for operations that we think are risky and want | ||
| # someone from ops to run manually and monitor. | ||
| # General advice is that if in doubt, mark your migration as `is_dangerous`. | ||
| # Some things you should always mark as dangerous: | ||
| # - Large data migrations. Typically we want these to be run manually by ops so that | ||
| # they can be monitored. Since data migrations will now hold a transaction open | ||
| # this is even more important. | ||
| # - Adding columns to highly active tables, even ones that are NULL. | ||
| is_dangerous = True | ||
|
|
||
| # This flag is used to decide whether to run this migration in a transaction or not. | ||
| # By default we prefer to run in a transaction, but for migrations where you want | ||
| # to `CREATE INDEX CONCURRENTLY` this needs to be set to False. Typically you'll | ||
| # want to create an index concurrently when adding one to an existing table. | ||
| # You'll also usually want to set this to `False` if you're writing a data | ||
| # migration, since we don't want the entire migration to run in one long-running | ||
| # transaction. | ||
| atomic = False | ||
|
|
||
| dependencies = [ | ||
| ("sentry", "0241_grouphistory_null_actor"), | ||
| ] | ||
|
|
||
| operations = [ | ||
| migrations.RunPython( | ||
| delete_removed_plugin_data, | ||
| migrations.RunPython.noop, | ||
| hints={"tables": ["sentry_projectoptions"]}, | ||
| ) | ||
| ] | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went back and forth on whether we needed this to be true or false, the amount of data is fairly small.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably the right choice to make it dangerous, just since the table has 5mm rows and it'll take a while to get through them all