Skip to content

fix(worldmap): Fix params that are passed to the endpoint #29671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shruthilayaj merged 1 commit into from
Nov 1, 2021
Merged

fix(worldmap): Fix params that are passed to the endpoint #29671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/sentry/integrations/slack/unfurl/discover.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,9 @@ def unfurl_discover(
# Only override if key doesn't exist since we want to account for
# an intermediate state where the query could have been cleared
if "query" not in params:
params.setlist("query", params.getlist("query") or to_list(saved_query.get("query")))
params.setlist(
"query", params.getlist("query") or to_list(saved_query.get("query", ""))
)

display_mode = str(params.get("display") or saved_query.get("display", "default"))

Expand Down Expand Up @@ -187,6 +189,8 @@ def unfurl_discover(
endpoint = "events-stats/"
if "worldmap" in display_mode:
endpoint = "events-geo/"
params.setlist("field", params.getlist("yAxis"))
params.pop("sort", None)

try:
resp = client.get(
Expand Down
2 changes: 1 addition & 1 deletion tests/sentry/integrations/slack/test_unfurl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,7 @@ def test_unfurl_world_map(self, mock_generate_chart):
project_id=self.project.id,
)

url = f"https://sentry.io/organizations/{self.organization.slug}/discover/results/?display=worldmap&field=count()&name=All+Events&project={self.project.id}&query=&statsPeriod=24h"
url = f"https://sentry.io/organizations/{self.organization.slug}/discover/results/?display=worldmap&field=title&field=event.type&field=project&field=user.display&field=timestamp&name=All+Events&project={self.project.id}&query=&sort=-timestamp&statsPeriod=24h&yAxis=count%28%29"
link_type, args = match_link(url)

if not args or not link_type:
Expand Down