Skip to content

feat(suspect-spans): Add rollout percentage option #29692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zylphrex merged 1 commit into from
Nov 1, 2021
Merged

feat(suspect-spans): Add rollout percentage option #29692

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/sentry/options/defaults.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,10 @@
# removed once it is fully rolled out.
register("symbolicate-event.low-priority.metrics.submission-rate", default=0.0)

# This is to enable the ingestion of suspect spans by project ids.
register("performance.suspect-spans-ingestion-projects", default={})
# This is to enable the ingestion of suspect spans by project groups.
register("performance.suspect-spans-ingestion.rollout-rate", default=0)
Copy link
Member

@dashed dashed Nov 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zylphrex would using FLAG_PRIORITIZE_DISK here be preferred?

Copy link
Member Author

@Zylphrex Zylphrex Nov 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm... I'll double check 👍


# Sampling rate for controlled rollout of a change where ignest-consumer spawns
# special save_event task for transactions avoiding the preprocess.
Expand Down