Skip to content

fix(suspect-spans): Span ops endpoint should not be paged yet #29749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zylphrex merged 1 commit into from
Nov 4, 2021
Merged

fix(suspect-spans): Span ops endpoint should not be paged yet #29749

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions static/app/views/performance/transactionSummary/transactionSpans/opsFilter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,8 @@ export default function OpsFilter(props: Props) {
location={location}
orgSlug={organization.slug}
eventView={opsFilterEventView}
cursor="0:0:1"
Copy link
Member

@k-fish k-fish Nov 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another one? Hmmmmm there should be a cleaner approach than this. I think maybe we should have a way for queries to change which url param they (or the EventView payload function that gets called) looks at for the cursor, and use null to indicate that the EventView should not use the location cursor?

Copy link
Member Author

@Zylphrex Zylphrex Nov 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, there should definitely be a clean way to handle this. Going to merge this for now and revisit later.

noPagination
>
{({spanOps, isLoading, error}) => {
if (isLoading) {
Expand Down