Skip to content

fix(suspect-spans): Span frequency should never exceed 100% #29754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zylphrex merged 1 commit into from
Nov 4, 2021
Merged

fix(suspect-spans): Span frequency should never exceed 100% #29754

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions static/app/views/performance/transactionSummary/transactionSpans/suspectSpanCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,14 +190,22 @@ function SpanCount(props: HeaderItemProps) {
);
}

// Because the frequency is computed using `count_unique(id)` internally,
// it is an approximate value. This means that it has the potential to be
// greater than `totals.count` when it shouldn't. So let's clip the
// frequency value to make sure we don't see values over 100%.
const frequency = defined(totals?.count)
? Math.min(suspectSpan.frequency, totals!.count)
: suspectSpan.frequency;

const value = defined(totals?.count) ? (
<Tooltip
title={tct('[frequency] out of [total] transactions contain this span', {
frequency: suspectSpan.frequency,
frequency,
total: totals!.count,
})}
>
<span>{formatPercentage(suspectSpan.frequency / totals!.count)}</span>
<span>{formatPercentage(frequency / totals!.count)}</span>
</Tooltip>
) : (
String(suspectSpan.count)
Expand Down