Skip to content

fix(ui): Fix alert condition display for old alert conditions without comparisonType #29791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taylangocmen merged 1 commit into from
Nov 4, 2021
Merged

fix(ui): Fix alert condition display for old alert conditions without comparisonType #29791

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions static/app/views/alerts/issueRuleEditor/ruleNodeList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,12 @@ class RuleNodeList extends React.Component<Props> {
},
};

// item.comparison type isn't backfilled and is missing for old alert rules
// this is a problem when an old alert is being edited, need to initialize it
if (!item.comparisonType && item.value && item.name) {
item.comparisonType = item.comparisonInterval === undefined ? 'count' : 'percent';
}

if (item.comparisonType) {
changeAlertNode = {
...changeAlertNode,
Expand Down